Page 1 of 1

Belfry - unit json 2(implementing a new unit) PASSED

Posted: Mon Jun 18, 2018 10:47 pm
by Stratego (dev)
Your next mission is the same as were for Samuel: "Samuel - unit json 2(implementing a new unit)"

Re: Belfry - unit json 2(implementing a new unit)

Posted: Sun Jun 24, 2018 9:28 pm
by Belfry777
Should I just look at his post?

Re: Belfry - unit json 2(implementing a new unit)

Posted: Mon Jun 25, 2018 6:49 am
by Stratego (dev)
yes

Re: Belfry - unit json 2(implementing a new unit)

Posted: Sun Jul 08, 2018 8:01 pm
by Belfry777
Okay sorry for putting the file on Sam's topic. Here it is.

Re: Belfry - unit json 2(implementing a new unit)

Posted: Mon Jul 09, 2018 10:04 pm
by Belfry777
Stratego (dev) wrote:
Mon Jun 18, 2018 10:47 pm
Your next mission is the same as were for Samuel: "Samuel - unit json 2(implementing a new unit)"
Is this good?

Re: Belfry - unit json 2(implementing a new unit)

Posted: Fri Jul 13, 2018 5:45 am
by Stratego (dev)
seems good but you missed things

this was the task:
- name the image properly
- make a json for it (start from a similar)
- make sure it is a mapeditor unit only


deliverables
- unit json (with new ID, next jJP id can be used: 707)
- image with nice name, and working "team coloring"
- image texting "name" and "flavour text"
- order in the buildlist json (indicating where to put this in list)
you still need these to finish:
- unit json (with new ID, next jJP id can be used: 707)
- image with nice name, and working "team coloring"
- image texting "name" and "flavour text"
- order in the buildlist json (indicating where to put this in list)[/quote]
- EXTRA: since then we have 2 images and 2 stages: occupied and unoccupied, if you can make it that is extra good! - no problem if not.
- EXTRA2: you need this sound definition too: {"soundEvent":"UNIT_ATTACK","packName":"SOUND_PACK_UNIT_ATTACK_TANK_SHOOT"},

Re: Belfry - unit json 2(implementing a new unit)

Posted: Fri Aug 10, 2018 10:12 pm
by Belfry777
Should I replace "JP" with 707?

Re: Belfry - unit json 2(implementing a new unit)

Posted: Sat Aug 11, 2018 7:40 am
by godOfKings
no, change unit type from 331 to 707

Re: Belfry - unit json 2(implementing a new unit)

Posted: Sun Aug 12, 2018 10:31 pm
by Belfry777
godOfKings wrote:
Sat Aug 11, 2018 7:40 am
no, change unit type from 331 to 707
Thanks for the help mate!

Re: Belfry - unit json 2(implementing a new unit)

Posted: Sun Aug 12, 2018 10:32 pm
by Belfry777
Here is the Json the post was working up.

Re: Belfry - unit json 2(implementing a new unit)

Posted: Sun Aug 19, 2018 5:57 am
by Stratego (dev)
nice!

but you missed things:

Pu55intheBoots gave JP fixed artillery image so here the tasks
- name the image properly
- make a json for it (start from a similar)
- make sure it is a mapeditor unit only


deliverables
- unit json (with new ID, next jJP id can be used: 707)
- image with nice name, and working "team coloring"
- image texting "name" and "flavour text"
- order in the buildlist json (indicating where to put this in list)
- EXTRA: since then we have 2 images and 2 stages: occupied and unoccupied, if you can make it that is extra good! - no problem if not.
- EXTRA2: you need this sound definition too: {"soundEvent":"UNIT_ATTACK","packName":"SOUND_PACK_UNIT_ATTACK_TANK_SHOOT"},


when you are please reply me to all bullets, so you and me can be sure you have not missed anything. thanks!

Re: Belfry - unit json 2(implementing a new unit)

Posted: Tue Aug 21, 2018 12:13 am
by Belfry777
Stratego (dev) wrote:
Sun Aug 19, 2018 5:57 am
nice!

but you missed things:

Pu55intheBoots gave JP fixed artillery image so here the tasks
- name the image properly
- make a json for it (start from a similar)
- make sure it is a mapeditor unit only


deliverables
- unit json (with new ID, next jJP id can be used: 707)
- image with nice name, and working "team coloring"
- image texting "name" and "flavour text"
- order in the buildlist json (indicating where to put this in list)
- EXTRA: since then we have 2 images and 2 stages: occupied and unoccupied, if you can make it that is extra good! - no problem if not.
- EXTRA2: you need this sound definition too: {"soundEvent":"UNIT_ATTACK","packName":"SOUND_PACK_UNIT_ATTACK_TANK_SHOOT"},


when you are please reply me to all bullets, so you and me can be sure you have not missed anything. thanks!
Okay... I don't know how to:

- image with nice name, and working "team coloring"
- image texting "name" and "flavour text"
- order in the buildlist json (indicating where to put this in list)
- make sure it is a mapeditor unit only

If you know please tell me!

Re: Belfry - unit json 2(implementing a new unit)

Posted: Wed Sep 05, 2018 9:00 pm
by Belfry777
Here are the images.

Re: Belfry - unit json 2(implementing a new unit)

Posted: Wed Sep 05, 2018 10:19 pm
by Belfry777
Here is the strings

<string name="UNIT_JP_BLD_CONCRETE_ARTILLERY">JP Concrete Artillery</string>
<string name="UNIT_TXT_JP_BLD_CONCRETE_ARTILLERY">Concrete artillery are very tough units that deliver moderate fire power.</string>

Re: Belfry - unit json 2(implementing a new unit)

Posted: Thu Sep 06, 2018 5:41 am
by Stratego (dev)
seems good! tell me if all taska are fulfilled and i will check! thanks!

Re: Belfry - unit json 2(implementing a new unit)

Posted: Fri Sep 07, 2018 5:58 pm
by Belfry777
Thanks to Pussinboots I was able to complete this. I don't have the buildlist, but every thing else is good. I need help to find the strings for future projects. By the way please check.

Re: Belfry - unit json 2(implementing a new unit)

Posted: Tue Sep 11, 2018 9:27 pm
by Belfry777
You still there Stratego?

Re: Belfry - unit json 2(implementing a new unit)

Posted: Thu Sep 13, 2018 10:09 pm
by Stratego (dev)
cool, please send me everything in one email so i can put in - thanks!

Re: Belfry - unit json 2(implementing a new unit)

Posted: Fri Sep 14, 2018 10:51 pm
by Belfry777
I sent them to you. How are they?

Re: Belfry - unit json 2(implementing a new unit)

Posted: Thu Sep 20, 2018 8:13 pm
by Stratego (dev)
problems i've found
- unt typename was wrong not JAP but JP (as in the texting)
- there is no sich race as JP, where have u seen it?
- you set it to "needOccupacyDisplay" = false, that is needed to be true
- there was no occupied image defined in json.
- there was missing comma in the sound section - have u checked with json validator?
- you gave there builders however it should not to be able to build
- also in buildlist was in wrong place among the buildables, however it should be in the non-buildables section

see fixed files attached, and compare it to yours to see the differences.

Re: Belfry - unit json 2(implementing a new unit)

Posted: Thu Sep 20, 2018 9:30 pm
by Belfry777
Here they are, I have fixed them.

<string name="UNIT_JAP_BLD_CONCRETE_ARTILLERY">JAP Concrete Artillery</string>
<string name="UNIT_TXT_JAP_BLD_CONCRETE_ARTILLERY">Concrete artillery are very tough units that deliver moderate fire power.</string>

I didn't put JAP because it is a derogatory term here in the U.S. But I don't think it will be a problem because we are not using it in a offensive way.

Re: Belfry - unit json 2(implementing a new unit)

Posted: Fri Sep 21, 2018 4:31 am
by Stratego (dev)
json: your json is wrong again in some bullets i wrote u, btw i have posted the fixed one, please COMPARE to yours so you will see
(now you even set this unit to be a technology..)

JAP, JP: i have used JP, not JAP

Re: Belfry - unit json 2(implementing a new unit)

Posted: Tue Sep 25, 2018 2:12 pm
by Belfry777
Okay I have sent the JSON VIA email.

Re: Belfry - unit json 2(implementing a new unit)

Posted: Tue Apr 16, 2019 4:41 pm
by Belfry777
Is this done? @Stratego (dev)

Re: Belfry - unit json 2(implementing a new unit)

Posted: Tue Apr 16, 2019 5:18 pm
by Stratego (dev)
sorry, i dont remember, please resend the email so i can see what was my answer. thanks!

Re: Belfry - unit json 2(implementing a new unit)

Posted: Thu Nov 07, 2019 1:57 am
by Belfry777
Hi! Here the Jsons should be complete. I have checked both with the validator.

<string name="UNIT_JP_BLD_CONCRETE_ARTILLERY">JP Concrete Artillery</string>
<string name="UNIT_TXT_JP_BLD_CONCRETE_ARTILLERY">Concrete artillery are very tough units that deliver moderate fire power.</string>

Re: Belfry - unit json 2(implementing a new unit) PASSED

Posted: Thu Nov 07, 2019 5:44 am
by Stratego (dev)
:)

at first glance seems good :)

Re: Belfry - unit json 2(implementing a new unit) PASSED

Posted: Thu Nov 07, 2019 11:48 am
by Puss_in_Boots
Great job! :)

Re: Belfry - unit json 2(implementing a new unit) PASSED

Posted: Thu Nov 07, 2019 5:34 pm
by Belfry777
Thanks for all your help boots! Now we can move to another job!